Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quantcastBidAdapter to pass quantcast fpa in the bid request #5947

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

mckurt
Copy link
Contributor

@mckurt mckurt commented Nov 9, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This PR updates Quantcast bidding adapter to read the Quantcast first party cookie and include it in the bid request. Please contact asig@quantcast.com for any issues.

@@ -70,7 +70,6 @@ export const spec = {
schain: bid.schain || {},
};
const mediaType = bid.mediaTypes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was complaining about this line, so I removed it:

"/home/circleci/Prebid.js/modules/lunamediahbBidAdapter.js
73:1 error Trailing spaces not allowed no-trailing-spaces"

@robertrmartinez robertrmartinez self-assigned this Nov 13, 2020
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mckurt
Copy link
Contributor Author

mckurt commented Nov 15, 2020

@robertrmartinez Thanks for the review. When can we merge this PR?

@@ -18,6 +19,9 @@ export const QUANTCAST_TEST_PUBLISHER = 'test-publisher';
export const QUANTCAST_TTL = 4;
export const QUANTCAST_PROTOCOL = 'https';
export const QUANTCAST_PORT = '8443';
export const QUANTCAST_FPA = '__qca';

export const storage = getStorageManager();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Quantcast have a registered GVL id?

Passing the following will allow storage access when GDPR Enforcement is enabled.
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do. I updated the code accordingly. Thanks for the catch.

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@robertrmartinez robertrmartinez merged commit c04bd6d into prebid:master Nov 17, 2020
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
…rebid#5947)

* update quantcastBidAdapter to pass quantcast fpa in the bid request

* remove empty line from lunamediahBidAdapter

* pass quantcast vendor id when obtaining storage manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants