[AD-1043] JW Player RTD - add targeting info to bid.rtd #5950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
approved these changes
Nov 10, 2020
|
LGTM, @bretg should we wait for @TheMediaGrid review before merging? |
TheMediaGrid
approved these changes
Nov 12, 2020
stsepelin
pushed a commit
to cointraffic/Prebid.js
that referenced
this pull request
May 28, 2021
* adds targeting to rtd * updates tmg module * updates unit tests * shortens realTimeData * updates grid adapter for rtd Co-authored-by: karimJWP <karimJWP@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Per @bretg 's request, we are setting our targeting information to the bid's shared
rtdobject.Since this is an API breaking change, we implemented the necessary changes for
gridBidAdapterand will request that the owner @TheMediaGrid review this PR.For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
requesting review by @bretg and @TheMediaGrid
docs PR: prebid/prebid.github.io#2485