Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CriteoId] Add local storage check and migrate cookie check to use StorageManager API #5953

Merged
merged 2 commits into from
Nov 16, 2020
Merged

[CriteoId] Add local storage check and migrate cookie check to use StorageManager API #5953

merged 2 commits into from
Nov 16, 2020

Conversation

jesusalber1
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Changes in the CriteoIdSystem:

  • Add check to know whether local storage is writable.
  • [Upgrade] Use the StorageManager API for cookie check, deprecating the previous one.

Contacts

FilipStamenkovic
FilipStamenkovic approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilipStamenkovic FilipStamenkovic merged commit 840c04d into prebid:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipStamenkovic FilipStamenkovic FilipStamenkovic approved these changes

Assignees

@FilipStamenkovic FilipStamenkovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesusalber1 @FilipStamenkovic