Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sharedIdSystem.js #5988

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Update sharedIdSystem.js #5988

merged 1 commit into from
Nov 17, 2020

Conversation

jdwieland8282
Copy link
Member

adding GVLID variable and spec definition, will come back and add it to getStorageManager once if I find that function referenced in the sharedid module.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

adding GVLID variable and spec definition, will come back and add it to getStorageManager once if I find that function referenced in the sharedid module.
@smenzer smenzer linked an issue Nov 17, 2020 that may be closed by this pull request
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer merged commit 842f21c into master Nov 17, 2020
@smenzer smenzer deleted the jdwieland8282-patch-1 branch November 17, 2020 10:26
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
adding GVLID variable and spec definition, will come back and add it to getStorageManager once if I find that function referenced in the sharedid module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Prebid GVL ID to PubCommon and SharedID User modules
3 participants