UID 2.0 Userid submodule

[SKOCHERI]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[patmmccann]

refs: sharedid, is this on purpose?

[patmmccann]

spelling

[patmmccann]

does this not work with local storage? or is storage.getCookie smart enough to check there if config says this should be in local storage?

[SKOCHERI]

UID 2.0 submodule relies on cookie '__uid2_advertising_token' which is set by UID 2.0 SSO

[pm-harshad-mane]

LGTM

[patmmccann]

Generally all my comments are around this question: Is there an opportunity to fix UID 2.0 SSO so it writes '__uid2_advertising_token' to html5? If not, a bunch of the doc on this commit needs changing to indicate this is a cookie only module.

Can we at least fallback to local storage like https://github.com/prebid/Prebid.js/blob/master/modules/zeotapIdPlusIdSystem.js does?

Also why write __uid2_advertising_token only to copy it to pbjs.uid20 or whatever. How about we just use one key instead of copying the value around, assuming we have control of this module as well?

[smenzer]

I know this module is "Unified ID v2.0", shortened to "UID2.0" ... but in the code by removing the "dot", it just looks like "UID twenty". can everything just be made "uid2" instead?

otherwise, my main comment is around the storage config, which isn't necessary (and in fact, is duplicative) since you're pulling from a hardcoded cookie/local storage name. removing this publisher setup for this would simplify several parts of this module

[smenzer]

what's the purpose of setting this const when it's just used once and immediately on the line below?

[SKOCHERI]

@patmmccann @smenzer Have updated to read from cookie /local storage and removed the storage config.

[patmmccann]

thanks for incorporating all my feedback

[patmmccann]

My comments are all resolved on the code but I don't see the link to the docs repo pr

[smenzer]

Just need the docs PR and then I can go ahead and merge this.

[jdwieland8282]

dev docs prebid/prebid.github.io#2798

[smenzer]

dev docs prebid/prebid.github.io#2798

thanks @jdwieland8282. this LGTM now so I'll go ahead and merge it.