Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdYouLike Bidder: Handle advertiser domains #6916

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Conversation

ChrisHuie
Copy link
Collaborator

@ChrisHuie ChrisHuie commented Jun 2, 2021

PR #6889 had other prs pulled in upstream. Resubmitted for original pr submitted by guiaan. This separates out just Adyoulike. I reviewed this but adding @patmmccann on for visibility

@guiann
Copy link
Contributor

guiann commented Jun 2, 2021

Thanks Chris,
It seems it's missing the update on file:
/test/spec/modules/adyoulikeBidAdapter_spec.js

for corresponding update on unit tests.

@ChrisHuie
Copy link
Collaborator Author

@guiann just added it. :)

@ChrisHuie ChrisHuie merged commit f957aa7 into master Jun 2, 2021
@ChrisHuie ChrisHuie deleted the ChrisHuie-adyoutlike branch June 2, 2021 11:28
AlvaroBrey pushed a commit to Parrable/Prebid.js that referenced this pull request Jun 2, 2021
…FilterStatus' into PBID-96_requestFilterStatus

* origin/parrableIdSystem/PBID-96_requestFilterStatus: (63 commits)
  Smaato bid adapter: Rework multi imp support (prebid#6814)
  Adot Bid Adapter: add the advertising domains support (prebid#6876)
  Update Adtelligent, Adtarget, ViewDeos   adapters to support adomain (prebid#6917)
  LockerDome Bid Adapter: support for meta.advertiserDomains  (prebid#6921)
  Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920)
  Brightcom Bid Adapter: use getFloor function (prebid#6918)
  AdYouLike Bidder: Handle advertiser domains (prebid#6916)
  relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914)
  Jixie Bid Adapter: add support for advertiserDomains (prebid#6898)
  Onomagic Bid Adapter: use getFloor function (prebid#6907)
  Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874)
  Accept outstream renderers defined in mediatype for PBS (prebid#6896)
  Yieldmo Bid Adapter: read video parameters from the ad unit (prebid#6873)
  smartx Bid Adapter: Add support for Floors Module (prebid#6902)
  add support for advertiser domains (prebid#6908)
  Onomagic Bid Adapter: handle meta.advertiserDomains (prebid#6906)
  Brightcom Bid Adapter: handle meta.advertiserDomains (prebid#6905)
  ucfunnel Bid Adapter: add support Price Floors Module (prebid#6806)
  eTarget Bid Adapter: add "getMetaData" function to adapter, support for advertiserDomains  (prebid#6901)
  AdagioBidAdapter: support priceFloors module (prebid#6867)
  ...
K-JBoon added a commit to bluebillywig/Prebid.js that referenced this pull request Jun 3, 2021
* 'master' of github.com:prebid/Prebid.js: (303 commits)
  BridgewellBidAdapter: modify to include user ids in the bid request object (prebid#6845)
  GridNMBidAdapter: Use absent in video params data from mediaTypes (prebid#6817)
  PubMatic: For Video: bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array (prebid#6926)
  Increment pre version
  Prebid 4.42.0 Release
  Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain (prebid#6888)
  Medianet bid adapter: MD update for video parameters. (prebid#6922)
  dgkeyword RTD Provider: add new real time data module  (prebid#6912)
  Smaato bid adapter: Rework multi imp support (prebid#6814)
  Adot Bid Adapter: add the advertising domains support (prebid#6876)
  Update Adtelligent, Adtarget, ViewDeos   adapters to support adomain (prebid#6917)
  LockerDome Bid Adapter: support for meta.advertiserDomains  (prebid#6921)
  Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920)
  Brightcom Bid Adapter: use getFloor function (prebid#6918)
  AdYouLike Bidder: Handle advertiser domains (prebid#6916)
  relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914)
  Jixie Bid Adapter: add support for advertiserDomains (prebid#6898)
  Onomagic Bid Adapter: use getFloor function (prebid#6907)
  Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874)
  Accept outstream renderers defined in mediatype for PBS (prebid#6896)
  ...
@guiann
Copy link
Contributor

guiann commented Jun 4, 2021

this change concern issue: #6650

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* AdYouLike Bidder: Handle advertiser domains

* fix linting

* update tests

* fix linting

* fix error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants