Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ats analytics set sampling rate to 1 percent #7010

Merged

Conversation

mamatic
Copy link
Contributor

@mamatic mamatic commented Jun 11, 2021

Type of change

  • Bugfix
  • Refactoring (no functional changes, no api changes)

Description of change

  • Change sampling rate to be 100 always and if sampling rate is 0 do not fire analytics request. If sampling rate is set something other then 0, set it to 100.

Other information

@smenzer

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkendall07 mkendall07 merged commit baf906b into prebid:master Jun 16, 2021
@mkendall07
Copy link
Member

@mamatic if you want this to be supported in 4.x please also open a PR against that branch https://github.com/prebid/Prebid.js/tree/4.43.x-legacy

@mamatic
Copy link
Contributor Author

mamatic commented Jun 17, 2021

@mamatic if you want this to be supported in 4.x please also open a PR against that branch https://github.com/prebid/Prebid.js/tree/4.43.x-legacy

OK, thanks for info. Sure, I will do it.

AlvaroBrey pushed a commit to Parrable/Prebid.js that referenced this pull request Jun 17, 2021
* master: (103 commits)
  Opt Out Bid Adapter: add new bid adapter (prebid#7029)
  Dependencies/Testing: update dependencies, npm audit fixes, and bump Browserstack versions (prebid#6828)
  5.2.0-pre
  Prebid.js 5.1.0
  IX Bid Adapter :  reading video `placement` property (prebid#6994)
  changing PBS debug flag to boolean (prebid#7035)
  Ats analytics set sampling rate to 1 percent (prebid#7010)
  Update sspBC bid adapter (v5.0) (prebid#7002)
  Gamma Bid Adapter: support adomain for Prebid 5.0 (prebid#7033)
  Datablocks Bid Adapter : update bid adapter and add 5.0 compliance (prebid#6765)
  Add microadBidAdapter (prebid#7007)
  Adf Bid Adapter: add adform alias (prebid#7009)
  Fixed FPD issue after for Prebid.js 5.0 (prebid#7031)
  Zeta Ssp Bid Adapter: provide devicetype (prebid#7026)
  make sizes a variable as the code expects (prebid#7024)
  VidazooBidAdapter: support for response meta.advertiserDomains (v5.0) (prebid#7022)
  add uid2 to OpenX Bid Adapter (prebid#7015)
  Zeta Ssp Bid Adapter: page and domain fields from config (prebid#7019)
  tappx Bid Adapter: fix wrong requests with undefined params (prebid#7021)
  RealVu Analytics Adapter: remove "tablet" from device types (prebid#7016)
  ...
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* ATS-analytics-adapter - Change sampling rate to 100

* ATS-analytics-adapter - add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants