-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmd Id System: add rest endpoint #7066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule feat(module):dmd user id module[PREBID-1]
…id-params feat(prebid):additional parameter[PREB-1]
…rage test(prebid):added more test coverage[PREB-11]
…esolution-on-upstream
fix(releasenote):removed unnecessary release note[PREB-11]
Fix/merge resolution on upstream
fix(test):updated failing test cases[PREB-11]
…rty_cookie PREB-26 Reading third party cookies from dmdId module implemented
…redentials-request Feature/preb 26 enable with credentials request
ops(merge): Correct resolution on markdown conflict
ops(merge): Correct resolution on spec conflict
…esolution fix(conflict):Merge conflicts from upstream master are resolved
…overage Feature/preb 26 adding test coverage
Modifications to unit tests
ChrisHuie
changed the title
Dmd Id System: add handling for
Dmd Id System: add rest endpoint
Jun 22, 2021
smenzer
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
* feat(prebid): DMD UserID Module reading from 1st party cookie [PREBID-1] * feat(prebid):additional parameter[PREB-1] * feat(prebid):update decode function and cacheobi[PREB-1] * test(prebid):added more test coverage[PREB-11] * feat(typo):cleared typo[PREB-11] * test(prebid):updated test cases[PREB-11] * feat(releasenote):added a release note[PREB-11] * fix(releasenote):removed unnecessary release note[PREB-11] * fix(test):updated failing test cases[PREB-11] * PREB-26 Reading third party cookies from dmdId module implemented * PREB-26 PR Comments resolved * fix(tests):Removed ascretion make sure we can use this code in multiple envs * fix(tests):Added ascretion to check request url * feat(credentials): Enabling with credential flag in ajax request * feat(credentials): Enabling with credential flag * feat(credentials): changed callback response from object to dgid string * ops(merge): Correct resolution on markdown conflict * ops(merge): Correct resolution on spec conflict * fix(conflict):Merge conflicts from upstream master are resolved * fix(unit testing): fixed test cases Co-authored-by: Matt Fitzgerald <matthewfitz@gmail.com> Co-authored-by: boppudikarthikc <boppudikarthikc@gmail.com> Co-authored-by: Karthik Boppudi <kboppudi@kboppudimac0518.local> Co-authored-by: mfitzgerald_dmd <mfitzgerald@dmdconnects.com> Co-authored-by: karthik <60045218+boppudikarthikc@users.noreply.github.com> Co-authored-by: Jay Kandimalla <jkandimalla@jkandimac0421.local> Co-authored-by: Jay kandimalla <jkandimalla@dmdconnects.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Reading dmdId (dgid) from third party REST endpoint imlemented.
-contact : prebid@dmdconnects.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
@matthewfitz @boppudikarthikc