Renderer Testing: fix the renderer tests so they can be run on their own #7070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- running ./node_modules/gulp/bin/gulp.js test --file test/spec/renderer_spec.js fails without this change. The adUnits global is set by other tests, and the adloaderSub is loaded by test_index.js. When you run this file on it's own, it will fail.
|
There might be a better and/or more generic fix for this in karma.conf.maker.js. test/spec/adUnits_spec.js, test/spec/auctionmanager_spec.js and test/spec/video_spec.js all fail if you try to run them on their own. |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
running ./node_modules/gulp/bin/gulp.js test --file test/spec/renderer_spec.js fails without this change. The adUnits global is set by other tests, and the adloaderStub is loaded by test_index.js. When you run this file on it's own, it will fail.