akamaiDAPIdSystem:add new ID submodule #7084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smenzer
requested changes
Jun 24, 2021
| apiHostname: 'api.dap.akadns.net', | ||
| domain: 'forums-jedi.akamaized.net', | ||
| type: 'email', | ||
| identity: 'aaryn@query.com' |
There was a problem hiding this comment.
this field isn't documented anywhere...should it be?
There was a problem hiding this comment.
Thanks @smenzer for highlighting this. These fields are mentioned in 'akamaiDAPIdSystem.md' readme file but I missed adding 'identity' field. I have updated it and also updated 'userId.md' file with same change.
Have provisioned a new (apiHostname: 'prebid.dap.akadns.net') for Prebid.org so updated the integration examples and spec files.
I have added tests to userId_spec.js file as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding the akamaiDAPId userId submodule.
contact email of maintainer: amishra@akamai.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
PR in docs repo: prebid/prebid.github.io#3058