Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revcontent Bid Adapter: adjusted for Price Floors Module #7093

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Revcontent Bid Adapter: adjusted for Price Floors Module #7093

merged 3 commits into from
Jul 6, 2021

Conversation

alexander-alexandrov
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Existing revcontentBidAdapter was adjusted to comply with Price Floors Module.
revcontentBidAdapter.md is already available in the repo.

alexander-alexandrov and others added 2 commits June 11, 2021 18:52
* REVC-3691 | Prebid.js support for price floors module | Call getFloor function; test-case is added

* REVC-3691 | 1 - Snippet with multi-items (#2)

* REVC-3691 | Prebid.js support for price floors module | Snippet for multi-item

* REVC-3691 | Prebid.js support for price floors module | Muti-item + fixed test-cases (#3)

* REVC-3691 | Prebid.js support for price floors module | Fixed demo pages

* REVC-3691 | Prebid.js support for price floors module | Added demo with multi-items
@ChrisHuie
Copy link
Collaborator

Looks like CircleCi tests weren't originally kicked off for this pr so manually kicked them off.

@ChrisHuie ChrisHuie requested review from ChrisHuie and removed request for idettman July 6, 2021 16:44
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned idettman Jul 6, 2021
@ChrisHuie ChrisHuie changed the title revcontentBidAdapter adjusted for Price Floors Module Revcontent Bid Adapter: adjusted for Price Floors Module Jul 6, 2021
@ChrisHuie ChrisHuie merged commit 568a90d into prebid:master Jul 6, 2021
ChrisHuie added a commit to prebid/prebid.github.io that referenced this pull request Jul 19, 2021
bretg pushed a commit to prebid/prebid.github.io that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants