Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medianet Bid Adapter: send screen size instead of browser size #7110

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Medianet Bid Adapter: send screen size instead of browser size #7110

merged 1 commit into from
Jun 28, 2021

Conversation

monis0395
Copy link
Contributor

Type of change

  • Feature

Description of change

Sending screen size instead of browser size in bid request

@ChrisHuie ChrisHuie self-requested a review June 28, 2021 07:47
@ChrisHuie ChrisHuie self-assigned this Jun 28, 2021
@ChrisHuie ChrisHuie changed the title Send screen size instead of browser size Medianet Bid Adapter: send screen size instead of browser size Jun 28, 2021
@monis0395
Copy link
Contributor Author

One test case is failing, which is also failing in latest master

1) should build utm data from local storage
     Prebid Manager Analytics Adapter build utm tag dat

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Jun 28, 2021 •
edited

One test case is failing, which is also failing in latest master

1) should build utm data from local storage
     Prebid Manager Analytics Adapter build utm tag dat

PR #7104 should fix this recent testing issue

@ChrisHuie ChrisHuie merged commit 6133237 into prebid:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monis0395 @ChrisHuie @monisq