Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iqm Bid Adapter: add new bid adapter #7111

Merged
merged 4 commits into from Jul 13, 2021
Merged

Conversation

Params10
Copy link
Contributor

@Params10 Params10 commented Jun 28, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added new IQM bid adapter

  • test parameters for validating bids
{
  bidder: 'iqm',
  params: {
             publisherId: 'df5fd732-c5f3-11e7-abc4-cec278b6b50a',
            placementId: 23451,
            bidfloor: 0.50,
            geo:{
                      country:'USA'
           },
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer :hbteam@iqm.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title Iqm bid adapter Iqm Bid Adapter: add new bid adapter Jun 29, 2021
@Params10
Copy link
Contributor Author

Params10 commented Jul 1, 2021

Hello @ChrisHuie can you help us out with why this adapter tests are failing at browser stack testing as it works fine on local setup.

@ChrisHuie ChrisHuie self-requested a review July 1, 2021 13:43
@ChrisHuie ChrisHuie self-assigned this Jul 1, 2021
@ChrisHuie ChrisHuie requested review from Rothalack and removed request for ChrisHuie July 1, 2021 13:51
@ChrisHuie ChrisHuie assigned Rothalack and unassigned ChrisHuie Jul 1, 2021
@ChrisHuie
Copy link
Collaborator

@Params10 we have a flaky ie test that was bad for a few days. If you pull in recent merges there is a fix in there that helps with it.

@Rothalack
Copy link
Collaborator

I've noticed a few things from trying to test.

There appears to be a change to package-lock.json, that may be my fault from testing, but please double check that you did not change the package settings on your end.

In testing, I'm getting a 400 Bad Request response from POST https://pdb.bids.iqm.com. I think I have the bidder set up properly so I would not expect that response. Let me know if you have any testing placement/publisher id to test with.

I see in your documentation PR prebid/prebid.github.io#3069 you have the geo/country setting in your example, but it's not listed in your params documentation. I would either update your documentation to show that geo/country is a param, or remove it from the example bidder to avoid any confusion.

@Rothalack
Copy link
Collaborator

Rothalack commented Jul 2, 2021

And pulling in master should help with the Circleci test.

@Params10
Copy link
Contributor Author

Hello, any updates for the pull request ?

@Rothalack
Copy link
Collaborator

Hey @Params10 . The merge with master fixed the package json issue and testing issues, so that's good to go.

That just leaves my question about your documentation regarding geo. I see in your test params here, geo is included, in your testing examples in your documentation it shows geo, then in your list of params in documentation, geo is not listed. I think you should either update your list of available params in documentation to include geo, or remove geo from your test examples. Without clearing that up, it will likely confuse users.

@Rothalack
Copy link
Collaborator

I see your update to your docs, this is good to go!

@Rothalack Rothalack merged commit 39dde9a into prebid:master Jul 13, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants