Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logicad Bid Adapter: Add meta.advertiserDomains support #7114

Conversation

logicad
Copy link
Contributor

@logicad logicad commented Jun 28, 2021

Type of change

  • Other

Description of change

Restore Logicad Bid Adapter for Prebid 5.x.
We fixed to set meta.advertiserDomains on a server side and added unit test of it.

  • test parameters for validating bids
{
  bidder: 'logicad',
  params: {
    tid: 'lfp-test-banner'
  }
}

@ChrisHuie ChrisHuie self-requested a review June 28, 2021 11:56
@ChrisHuie ChrisHuie self-assigned this Jun 28, 2021
@ChrisHuie
Copy link
Collaborator

@logicad is there a way to add adomain to the request here?

@logicad
Copy link
Contributor Author

logicad commented Jun 30, 2021

Hi @ChrisHuie
Thanks for the comment.
We fixed to set meta.advertiserDomains on a server side.
If you want to test, you can use the following test parameters.

{
  bidder: 'logicad',
  params: {
    tid: 'lfp-test-banner'
  }
}

Or does it mean that in addition to set bid.meta.advertiserDomains, bid.adomain is also required?

@ChrisHuie
Copy link
Collaborator

Hi @ChrisHuie
Thanks for the comment.
We fixed to set meta.advertiserDomains on a server side.
If you want to test, you can use the following test parameters.

{
  bidder: 'logicad',
  params: {
    tid: 'lfp-test-banner'
  }
}

Or does it mean that in addition to set bid.meta.advertiserDomains, bid.adomain is also required?

This is fine. Sorry didn't realize it was coming back from the server. See the unit test so we are good 👍

@ChrisHuie ChrisHuie merged commit 86489e1 into prebid:master Jul 1, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Co-authored-by: ytsuchiya <ytsuchiya@so-netmedia.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants