Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartico Bid Adapter: add adomain for Prebid 5.0 #7115

Merged
merged 13 commits into from Jul 12, 2021
Merged

Conversation

cs83
Copy link
Contributor

@cs83 cs83 commented Jun 28, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@cs83
Copy link
Contributor Author

cs83 commented Jun 28, 2021

@osazos

Hello, sir.
We made an update to our adapter, could you please check this and merge.
Thank you.

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Jun 29, 2021

@cs83 can you please fix the linting errors for this pr and also I don't see support for adomain which is now required in previd v5 per #6650

@ChrisHuie ChrisHuie changed the title Update for smartico adapter Smartico Bid Adapter: update adapter Jun 29, 2021
@ChrisHuie ChrisHuie self-requested a review June 29, 2021 16:32
@ChrisHuie ChrisHuie self-assigned this Jun 29, 2021
@ChrisHuie ChrisHuie changed the title Smartico Bid Adapter: update adapter Smartico Bid Adapter: add adomain Jun 29, 2021
@ChrisHuie ChrisHuie changed the title Smartico Bid Adapter: add adomain Smartico Bid Adapter: add adomain for Prebid 5.0 Jun 29, 2021
@ChrisHuie ChrisHuie merged commit dcd2789 into prebid:master Jul 12, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* Adding smartico adapter

* bug prebid#6486 fix, added maintainer email

* bug prebid#6486 fix, modified test parameters

* bug prebid#6486 fix, modified test parameters #2

* prebid#6486 applied review related updates & fixes

* prebid#6486 applied review related updates & fixes #2

* prebid#6486 applied review related updates & fixes #3

* samrtico adapter bug fix

* smartico adapter unit test update after bug fixing

* smartico adapter bug fix #2

* smartico adapter bug fix #3

* fix linting errors

Co-authored-by: Dmitri <dmitri@atomdev.net>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants