Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMOSSP Bid Adapter: add IM uid support #7134

Merged
merged 1 commit into from Jul 13, 2021

Conversation

matsumoto-kouichi
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

We have added new request parameter, Intimate Merger uid.
Since the uid is set in cookie, storageManager.js also has been added.

  • test parameters for validating bids
    {
    bidder: 'gmossp',
    params: {
    sid: '61590'
    }
    }
  • contact email of the adapter's maintainer
    dev@ml.gmo-am.jp
  • official adapter submission

@ChrisHuie ChrisHuie self-requested a review July 2, 2021 17:49
@ChrisHuie ChrisHuie self-assigned this Jul 2, 2021
@ChrisHuie ChrisHuie removed their request for review July 2, 2021 18:33
@ChrisHuie ChrisHuie removed their assignment Jul 2, 2021
@ChrisHuie ChrisHuie self-requested a review July 6, 2021 19:31
@ChrisHuie ChrisHuie self-assigned this Jul 6, 2021
@ChrisHuie
Copy link
Collaborator

@matsumoto-kouichi can you please pull in recent commits to master so our circleci tests pass before merging 🙏

@matsumoto-kouichi
Copy link
Contributor Author

@ChrisHuie I pulled and pushed from master, but the circle ci doesn't seem to go through in unrelated places.

@ChrisHuie
Copy link
Collaborator

@matsumoto-kouichi I was able to get it to pass :)

@ChrisHuie ChrisHuie merged commit a633a63 into prebid:master Jul 13, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants