Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID5 Analytics: redaction process skips 'ext' on ID5 ID #7141

Merged
merged 2 commits into from Jul 13, 2021
Merged

ID5 Analytics: redaction process skips 'ext' on ID5 ID #7141

merged 2 commits into from Jul 13, 2021

Conversation

cosenmarco
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Relaxes some aggressive cleanup in the ID5 Analytics module for data we need.

@smenzer smenzer changed the title #26 id5analytics redactin process skips 'ext' on ID5 ID ID5 Analytics: redaction process skips 'ext' on ID5 ID Jul 8, 2021
Fawke
Fawke approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 2852ab2 into prebid:master Jul 13, 2021
@Fawke Fawke added the LGTM label Jul 13, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@cosenmarco @agrandes-tappx
ID5 Analytics: redaction process skips 'ext' on ID5 ID (prebid#7141)
b7f789b 
* prebid#26 id5analytics redactin process skips 'ext' on ID5 ID

* prebid#26 stop using startsWith because IE11 doesn't like it

Co-authored-by: Marco Cosentino <mcosentino@id5.io>
@smenzer smenzer deleted the 26-avoid-filtering-the-ext-field-in-bids-for-the-id5-id branch August 2, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
LGTM maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cosenmarco @Fawke @smenzer