PubMatic Analytics Adapter: added support for Bidder alias

[pm-azhar-mulla]

Type of change

• Feature

Description of change

Added support for Bidder alias in pubmaticAnalyticsAdapter.
Added a new field "bc" to log the bidder code for adapter.

[aleksatr]

Hi @pm-azhar-mulla , I just noticed that these changes will work only if the bidder alias is all lowercase letters:

I've tried the following example:

var adUnits = [{
    code: 'div-gpt-ad-1460505748561-0',
    mediaTypes: {
        banner: {
            sizes: [[300, 250], [300,600]],
        }
    },
    // Replace this object to test a new Adapter!
    bids: [{
        bidder: 'bRealTime1',
        params: {
            placementId: 13144370
        }
    }]

}];

...

pbjs.que.push(function() {
    pbjs.aliasBidder('appnexus', 'bRealTime1');

    pbjs.addAdUnits(adUnits);

    pbjs.enableAnalytics({
        provider: 'pubmatic',
        options: {
            "publisherId": 12345 // please contact PubMatic to get a publisherId for yourself
        }
    });

    pbjs.requestBids({
        bidsBackHandler: sendAdserverRequest,
        timeout: PREBID_TIMEOUT
    });
});

...

And what I see get sent to your endpoint is ... "pn":"brealtime1","bc":"brealtime1" ...

[pm-azhar-mulla]

Hi @pm-azhar-mulla , I just noticed that these changes will work only if the bidder alias is all lowercase letters:

I've tried the following example:

var adUnits = [{
    code: 'div-gpt-ad-1460505748561-0',
    mediaTypes: {
        banner: {
            sizes: [[300, 250], [300,600]],
        }
    },
    // Replace this object to test a new Adapter!
    bids: [{
        bidder: 'bRealTime1',
        params: {
            placementId: 13144370
        }
    }]

}];

...

pbjs.que.push(function() {
    pbjs.aliasBidder('appnexus', 'bRealTime1');

    pbjs.addAdUnits(adUnits);

    pbjs.enableAnalytics({
        provider: 'pubmatic',
        options: {
            "publisherId": 12345 // please contact PubMatic to get a publisherId for yourself
        }
    });

    pbjs.requestBids({
        bidsBackHandler: sendAdserverRequest,
        timeout: PREBID_TIMEOUT
    });
});

...

And what I see get sent to your endpoint is ... "pn":"brealtime1","bc":"brealtime1" ...

Removed the code which was converting bidder to lowercase, @pm-harshad-mane you remember any reason why were converting bidder to lowercase?

[pm-azhar-mulla]

Can someone please re-run the test jobs (CI)

[aleksatr]

@pm-azhar-mulla if you can confirm that we can move forward with the removal of lowercase conversion (for bidder name), I can merge this.

[pm-harshad-mane]

Hello @aleksatr , @pm-azhar-mulla
Please go ahead with the change.