PulsePoint Bid Adapter: Support for first party eid data #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
anand-venkatraman
changed the title
|
This is not following a convention on how a publisher might specify an eid. They would specify it like this https://docs.prebid.org/dev-docs/modules/userId.html#pubprovided-configuration |
patmmccann
requested changes
Mar 24, 2022
There was a problem hiding this comment.
What's wrong with https://docs.prebid.org/dev-docs/modules/userId.html#pubprovided-configuration ?
Is there any documentation or examples of publishers using this additionalEid you are reading from?
|
@patmmccann - thanks for pointing that out, I have refactored our adapter to use the generic |
|
Thanks @anand-venkatraman ; please link a docs repo pull indicating your change in id support to 'all' but these changes LGTM |
patmmccann
approved these changes
Apr 4, 2022
|
Docs repo changes have been made - prebid/prebid.github.io#3689 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change