Prebid Core: send all bid info within the timeout event #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Apr 20, 2022
ChrisHuie
changed the title
ChrisHuie
added
the
needs 2nd review
|
@patmmccann double-checking this behavior with you to make sure I'm not missing any side-effects from this changee? |
|
This is the original PR: |
|
@JulieLorin what do you think about listing all the fields you want? Also, can you add a test for a field you are not getting now, showing that it is passed? |
|
@patmmccann The field I want is a custom one added on the bid (not something officially supported by Prebid) so I cannot really make a list. That's why I was proposing to keep all bid's fields just like it is done in the nobid event (it seems to be more consistent) The original PR was about adding more information (before, there was only the bidderCode) but I don't see a reason to limit it to only 4 fields. I will add a test for this |
JulieLorin
force-pushed
the
enh/timeout-bids
branch
from
9391088
to
665ebbe
Compare
|
lgtm |
patmmccann
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We are using the bids and no bids events (EVENTS.BID_TIMEOUT and EVENTS.NO_BID) and we do not retrieve the same information about the bid on both. The timeout event only has a few information. This is because most fields are not sent.
I don't know if there is a reason to keep only little information about the timeout event, but if it's ok, it would be convenient for us to have more information.
This pull request updates the timeout event and will send the original bid in the timeout event. There will be no removal or renaming of fields. This is only an addition of field.