Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinuteMedia - Add support for Banner #8292

Merged
merged 44 commits into from
May 4, 2022
Merged

Conversation

noamtzu
Copy link
Contributor

@noamtzu noamtzu commented Apr 17, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add support for Banner

  • test parameters for validating bids
{
          bidder: 'minutemedia',
          params: {
              org: '56f91cd4d3e3660002000033', // Required
              floorPrice: 0.05, // Optional
              placementId: '12345678', // Optional
              testMode: true // Optional
          }
      }

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
prebid/prebid.github.io#3708

@ncolletti
Copy link
Contributor

@noamtzu looks good, however, your markdown file is not updated to mention banner support. could you add that and include an example of the mediatype in the Test Parameters section, thank you!

@noamtzu
Copy link
Contributor Author

noamtzu commented Apr 30, 2022

@ncolletti fixed. Thanks 🙏🏻

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncolletti ncolletti merged commit d632468 into prebid:master May 4, 2022
@ncolletti ncolletti changed the title MimuteMedia - Add support for Banner MinuteMedia - Add support for Banner May 4, 2022
tpmn-admin pushed a commit to tpmn-admin/Prebid.js that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants