Jixie Bid adapter: support more userids #8314
Conversation
…6650 added response comment and some trivial code.
added a space behind the // in comments
…ain in unit tests
* jixie_add_keyword_frompage: added the code to get the keywords from the meta tags if available.
|
Please add docs |
|
Hi folks, I might need a bit of guidance here. To my PR (initial) I received a comment (earlier commit) from Patrick McCann saying "Please add docs". Since this pull request is about jixie changing to send userids to our backend, I looked at other bidders who are sending userids to their backends - to see what kind of comments/docs they have on this topic. I was unable to find. So here, I only added a rather lame comment in the md file (With this latest commit (updating the PR) I have actually changed the implementation too). Please let me know what kind of thing I should write about. THANKYOU! |
|
You should submit an accompanying pr for this change to this file https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/jixie.md in which you disclose your support for some userids. See https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/rtbhouse.md (or many other adapters) for an example disclosure. |
|
corresponding PR in the doc repo: |
| @@ -6,6 +6,7 @@ import { BANNER, VIDEO } from '../src/mediaTypes.js'; | |||
| import { ajax } from '../src/ajax.js'; | |||
| import { getRefererInfo } from '../src/refererDetection.js'; | |||
| import { Renderer } from '../src/Renderer.js'; | |||
| import {createEidsArray} from './userId/eids.js'; | |||
There was a problem hiding this comment.
@dgirardi please note another location this is occurring
There was a problem hiding this comment.
FWIW, this does not need to happen - adapters can just take validBidRequest.userIdsAsEids.
Type of change
Description of change
added code to sending tdid and uid2 and any publisher id to our backend
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information