Prebid Server Adapter: add native asset id parameter #8317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
reviewed
May 2, 2022
| try { | ||
| nativeAssets = nativeAssetCache[impressionId] = Object.keys(nativeParams).reduce((assets, type) => { | ||
| let params = nativeParams[type]; | ||
|
|
||
| function newAsset(obj) { | ||
| return Object.assign({ | ||
| required: params.required ? 1 : 0 | ||
| required: params.required ? 1 : 0, | ||
| id: (isNumber(params.id)) ? params.id : idCounter++ |
There was a problem hiding this comment.
@jsnellbaker - this doesn't cover the case where some assets have IDs and others don't. So there could wind up being duplicate IDs. I guess it might be ok to just document this behavior clearly.
There was a problem hiding this comment.
I agree it should be clearly documented, but I thought of a potential alternative that maybe could better handle the ids. I'll push the commit shortly, let me know if it's worthwhile.
bretg
approved these changes
May 2, 2022
patmmccann
approved these changes
May 2, 2022
patmmccann
changed the title
tpmn-admin
pushed a commit
to tpmn-admin/Prebid.js
that referenced
this pull request
May 9, 2022
* add missing native asset id param for PBS requests * use id if it exists * update id counter logic
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds in the missing
idfield(s) for thenative.request.assetsobject array of a PBS request. The ORTB native spec has this field denoted as required (see PDF link below).While leaving out the field did not appear to be an issue for some of the PBS endpoints, it was found to be an issue for the appnexus PSP endpoint.
Reference - OpenRTB Native doc:
https://www.iab.com/wp-content/uploads/2018/03/OpenRTB-Native-Ads-Specification-Final-1.2.pdf
-- section 4.2 (pg 13)