Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big Richmedia Bid adapter : use a 1x1 creative for skins #8327

Merged
merged 1 commit into from
May 6, 2022
Merged

Big Richmedia Bid adapter : use a 1x1 creative for skins #8327

merged 1 commit into from
May 6, 2022

Conversation

yki-t
Copy link
Contributor

@yki-t yki-t commented Apr 27, 2022

Type of change

Adapter update

Description of change

Update adapter bid response size

@patmmccann patmmccann changed the title Bid Richemedia adapter : use a 1x1 creative Big Richmedia Bif adapter : use a 1x1 creative Apr 29, 2022
@patmmccann patmmccann changed the title Big Richmedia Bif adapter : use a 1x1 creative Big Richmedia Bid adapter : use a 1x1 creative for skins Apr 29, 2022
patmmccann
patmmccann requested changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write a test

@patmmccann patmmccann self-assigned this Apr 29, 2022
@yki-t
Copy link
Contributor Author

yki-t commented May 6, 2022

@patmmccann

please write a test

Here is the test
https://github.com/prebid/Prebid.js/blob/master/test/spec/modules/big-richmediaBidAdapter_spec.js

Do you mean I need to write test for the change ?

@patmmccann patmmccann merged commit ce156c7 into prebid:master May 6, 2022
@saxsir saxsir mentioned this pull request Oct 5, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance needs unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yki-t @patmmccann