IX Bid Adapter: Add banner pos support #8892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
robhazan
reviewed
Aug 23, 2022
| @@ -171,7 +171,8 @@ describe('IndexexchangeAdapter', function () { | |||
| sizes: [[300, 250], [300, 600]], | |||
| mediaTypes: { | |||
| banner: { | |||
| sizes: [[300, 250], [300, 600]] | |||
| sizes: [[300, 250], [300, 600]], | |||
| pos: 0, | |||
There was a problem hiding this comment.
Nice catch! It's addressed.
ChrisHuie
approved these changes
Aug 26, 2022
patmmccann
reviewed
Aug 27, 2022
modules/ixBidAdapter.js
Outdated
| @@ -612,13 +612,15 @@ function buildRequest(validBidRequests, bidderRequest, impressions, version) { | |||
| r.ext.ixdiag.err = cachedErrors; | |||
| } | |||
|
|
|||
| // populate request source.tid | |||
| r.source = { | |||
| tid: validBidRequests[0].transactionId, | |||
There was a problem hiding this comment.
@robhazan what's your guys goal here? You already have this field on imp.ext.tid
There was a problem hiding this comment.
@patmmccann thanks for pointing that out, spoke to @robhazan about it and removed source tid logic from this MR.
shahinrahbariasl
changed the title
patmmccann
approved these changes
Aug 29, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* IX Bid Adapter: Add source tid and banner pos support * add missing semi * remove extra comma * update to check banner pos being int * remove source tid logic Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* IX Bid Adapter: Add source tid and banner pos support * add missing semi * remove extra comma * update to check banner pos being int * remove source tid logic Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add banner.pos support (video.pos is already supported).
contact shahin.rahbariasl@indexexchange.com for more information.