PBjs Core (Native): ortb tracker support #8905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
dgirardi
approved these changes
Aug 29, 2022
src/native.js
Outdated
| @@ -305,8 +305,27 @@ export function fireImpressionTrackers(nativeResponse, {runMarkup = (mkup) => in | |||
| } | |||
| } | |||
|
|
|||
| export function fireClickTrackers(nativeResponse, {fetchURL = triggerPixel} = {}) { | |||
| (nativeResponse.link?.clicktrackers || []).forEach(url => fetchURL(url)); | |||
| export function fireClickTrackers(nativeResponse, {fetchURL = triggerPixel, assetId} = {}) { | |||
There was a problem hiding this comment.
it's just style, but I'd prefer to either merge params together or keep dependencies separate from inputs (either fireClickTrackers({nativeResponse, assetId, {...dependencies}}) or fireClickTrackers(nativeResponse, assetId, {...dependencies}) look better to me).
There was a problem hiding this comment.
I prefer the first one.
patmmccann
approved these changes
Aug 31, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* handle clicktrackers the ORTB way * support for clicktrackers on assets * parameters are now explicitly defined Co-authored-by: Michele Nasti <michele@rtk.io>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* handle clicktrackers the ORTB way * support for clicktrackers on assets * parameters are now explicitly defined Co-authored-by: Michele Nasti <michele@rtk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Native ORTB spec allows clicktrackers to be defined on individual assets; this PR adds this feature, together with PUC #150.
Other information
Accompaining with prebid/prebid-universal-creative#150