Enrichment FPD Module: Support for GPC Detection #8925
Conversation
| validated = processFpd({}, {}).global; | ||
| expect(validated.regs).to.equal(undefined); | ||
|
|
||
| navigator.globalPrivacyControl = { gpc: 1 }; |
There was a problem hiding this comment.
as I read the proposal this should be true or false. However, I have two objections:
- aren't we doing this too early? none of my browsers set this, and it's not even mentioned on MDN. Is the proposal final and on its way to implementation?
- Once the navigator does set this, this test will not work right, because it's going to be a read-only field. I think you need to mock it here.
There was a problem hiding this comment.
just updated my PR. somehow missed the true or false part thanks for pointing that out. i think the test is ok now.
correct, from what i gathered as well, this functionality does still seem to be in it's early stages, not 100% sure when it will be fully implemented. it does state here how detection will occur though: https://global-privacy-control.glitch.me/ (was taken from https://globalprivacycontrol.org/, from the faq at the bottom under "I’m a publisher, developer, or other service. How can I support GPC?")
i was aiming to be proactive, however, as you mentioned because this is still in the proposal phase should we hold off entirely for the time being in case specifications change?
There was a problem hiding this comment.
I think it's OK because as it's written the worst that can happen is that we don't pick up the gpc flag. I'm just surprised that we'd get here before MDN :)
There was a problem hiding this comment.
haha i agree, MDN typically knows all. least the change on our end for this is pretty minimal/low-risk like you pointed out anyway
|
Thanks @jlquaccia !! |
* support for gpc detection * updated test name and some other minor changes * adjusted test Co-authored-by: Jason Quaccia <jasonquaccia@RWC-WS233.local>
* support for gpc detection * updated test name and some other minor changes * adjusted test Co-authored-by: Jason Quaccia <jasonquaccia@RWC-WS233.local>
Type of change
Description of change
Other information
#8424
https://global-privacy-control.glitch.me
@dgirardi can you review when you have time?