Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeWheel SSP Adapter: add support for video.plcmt #9978

Merged
merged 19 commits into from
May 22, 2023
Merged

FreeWheel SSP Adapter: add support for video.plcmt #9978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6c65639
FreeWheel add floor price
xwang202 Feb 7, 2023
16863e7
FreeWheel code update
xwang202 Feb 7, 2023
67b4f50
FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default
xwang202 Feb 14, 2023
39c312b
Merge branch 'master' of https://github.com/prebid/Prebid.js
xwang202 Mar 13, 2023
63cb73f
FreeWheel-SSP-Adapter add userIdAsEids support
xwang202 Mar 13, 2023
ace764c
Freewheel-SSP-Adapter add test for eids
xwang202 Mar 13, 2023
61f34b7
Merge branch 'master' of https://github.com/prebid/Prebid.js
xwang202 Mar 15, 2023
e5acc30
Freewheel SSP Adapter: add prebid version in request
xwang202 Mar 15, 2023
06cb184
code cleanup
xwang202 Mar 15, 2023
b6c29a9
Merge branch 'master' of https://github.com/prebid/Prebid.js
xwang202 Apr 11, 2023
117010c
FreeWheel SSP Bid Adapter: support video context and placement
xwang202 Apr 11, 2023
8acdef5
update test
xwang202 Apr 11, 2023
301e1e9
Merge branch 'master' of https://github.com/prebid/Prebid.js
xwang202 Apr 27, 2023
6704e00
FreeWheel SSP Bid Adapter: add GPP support
xwang202 Apr 27, 2023
abb0a98
Freewheel SSP Bid Adapter: test update
xwang202 Apr 27, 2023
5a956e6
FreeWheel SSP Adapter: update the default value for video placement a…
xwang202 May 19, 2023
5be14a7
update test
xwang202 May 19, 2023
093fcc2
fix the conflict
xwang202 May 22, 2023
30af5a4
FreeWheel SSP Adapter: add support for video.plcmt
xwang202 May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modules/freewheel-sspBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ export const spec = {
var timeInMillis = new Date().getTime();
var keyCode = hashcode(zone + '' + timeInMillis);
var bidfloor = getBidFloor(currentBidRequest, config);
var format = currentBidRequest.params.format;

var requestParams = {
reqType: 'AdsSetup',
Expand Down Expand Up @@ -435,10 +436,17 @@ export const spec = {

// Add video context and placement in requestParams
if (currentBidRequest.mediaTypes.video) {
var videoContext = currentBidRequest.mediaTypes.video.context ? currentBidRequest.mediaTypes.video.context : 'instream';
var videoPlacement = currentBidRequest.mediaTypes.video.placement ? currentBidRequest.mediaTypes.video.placement : 1;
var videoContext = currentBidRequest.mediaTypes.video.context ? currentBidRequest.mediaTypes.video.context : '';
var videoPlacement = currentBidRequest.mediaTypes.video.placement ? currentBidRequest.mediaTypes.video.placement : null;
var videoPlcmt = currentBidRequest.mediaTypes.video.plcmt ? currentBidRequest.mediaTypes.video.plcmt : null;

if (format == 'inbanner') {
videoPlacement = 2;
videoContext = 'In-Banner';
}
requestParams.video_context = videoContext;
requestParams.video_placement = videoPlacement;
requestParams.video_plcmt = videoPlcmt;
}

return {
Expand Down
7 changes: 5 additions & 2 deletions test/spec/modules/freewheel-sspBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,9 @@ describe('freewheelSSP BidAdapter Test', () => {
it('should return context and placement with default values', () => {
const request = spec.buildRequests(bidRequests);
const payload = request[0].data;
expect(payload.video_context).to.equal('instream'); ;
expect(payload.video_placement).to.equal(1);
expect(payload.video_context).to.equal(''); ;
expect(payload.video_placement).to.equal(null);
expect(payload.video_plcmt).to.equal(null);
});

it('should add parameters to the tag', () => {
Expand Down Expand Up @@ -367,6 +368,7 @@ describe('freewheelSSP BidAdapter Test', () => {
'video': {
'context': 'outstream',
'placement': 2,
'plcmt': 3,
'playerSize': [300, 600],
}
},
Expand All @@ -382,6 +384,7 @@ describe('freewheelSSP BidAdapter Test', () => {
const payload = request[0].data;
expect(payload.video_context).to.equal('outstream'); ;
expect(payload.video_placement).to.equal(2);
expect(payload.video_plcmt).to.equal(3);
});
})

Expand Down