Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Fix issues caused by metric system update #105

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

And1sS
Copy link
Member

@And1sS And1sS commented Aug 17, 2023

No description provided.

@Net-burst Net-burst linked an issue Aug 24, 2023 that may be closed by this pull request
Net-burst
Net-burst previously approved these changes Aug 24, 2023
Copy link
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Net-burst Net-burst linked an issue Aug 24, 2023 that may be closed by this pull request
@Value("${management.graphite.metrics.export.prefix:}") String prefix) {

return registry -> {
if (StringUtils.isNotBlank(prefix)) {
registry.config().commonTags("prefix", prefix);
}
// To preserve old metric names
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment will have no value for future developers

@SerhiiNahornyi SerhiiNahornyi merged commit 66ce71c into master Aug 29, 2023
2 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the metrics/fix-bump-issues branch August 29, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricsRecorderTimer issue MetricsConfig for Prometheus
3 participants