Update Dependencies - Part 2 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Mar 17, 2022
| {lvl: logrus.InfoLevel, msg: "config.metrics.influx.host: "}, | ||
| {lvl: logrus.InfoLevel, msg: "config.metrics.influx.database: "}, | ||
| {lvl: logrus.InfoLevel, msg: "config.metrics.influx.measurement: "}, | ||
| {lvl: logrus.InfoLevel, msg: "config.metrics.influx.align_timestamps: false"}, |
There was a problem hiding this comment.
I restructured the code to put each log expectation on its own line, which made it easier for me to read and understand.
| Measurement string `mapstructure:"measurement"` | ||
| Username string `mapstructure:"username"` | ||
| Password string `mapstructure:"password"` | ||
| AlignTimestamps bool `mapstructure:"align_timestamps"` |
There was a problem hiding this comment.
Should these two new values have to be added to func setConfigDefaults(v *viper.Viper) ?
| @@ -10,7 +10,7 @@ import ( | |||
| influxdb "github.com/vrischmann/go-metrics-influxdb" | |||
| ) | |||
|
|
|||
| var TenSeconds time.Duration = time.Second * 10 | |||
| const TenSeconds time.Duration = time.Second * 10 | |||
VeronikaSolovei9
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/prometheus/client_golang
github.com/rcrowley/go-metrics
github.com/vrischmann/go-metrics-influxdb
All metrics related dependencies have been updated to the same versions we are using in Prebid Server. We haven't seen any issues with these updates in Prebid Server, so I expect no issues for Prebid Cache. This does include breaking changes / new required fields for Influx metrics. Please see the details on the Prebid Server release notes: https://github.com/prebid/prebid-server/releases/tag/v0.198.0
github.com/sirupsen/logrus
We were 6 releases behind. The release notes indicate mostly just bug fixes.
github.com/stretchr/testify
We were only 1 minor release behind. This is used exclusively for tests and tests still pass.