PBM should not save the bid if targeting keys are not returned from server #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppuviarasu
reviewed
Aug 10, 2018
| adServerTargetingCopy[cacheIdkey] = bidderCacheId; | ||
| PBBidResponse *bidResponse = [PBBidResponse bidResponseWithAdUnitId:adUnitId adServerTargeting:adServerTargetingCopy]; | ||
| PBLogDebug(@"Bid Successful with rounded bid targeting keys are %@ for adUnit id is %@", [bidResponse.customKeywords description], adUnitId); | ||
| [bidResponsesArray addObject:bidResponse]; | ||
| } | ||
| [delegate didReceiveSuccessResponse:bidResponsesArray];; |
There was a problem hiding this comment.
Why are u sending didReceiveSuccessResponse when targeting keys are nil?
There was a problem hiding this comment.
check out the full code. I'm not sending didReceiveSuccessResponse when targeting keys are nil, that's inside bid response retrieval.
There was a problem hiding this comment.
Again questioning... why would u send success if this bidResponsesArray is nil or empty?
ppuviarasu
approved these changes
Aug 16, 2018
| adServerTargetingCopy[cacheIdkey] = bidderCacheId; | ||
| PBBidResponse *bidResponse = [PBBidResponse bidResponseWithAdUnitId:adUnitId adServerTargeting:adServerTargetingCopy]; | ||
| PBLogDebug(@"Bid Successful with rounded bid targeting keys are %@ for adUnit id is %@", [bidResponse.customKeywords description], adUnitId); | ||
| [bidResponsesArray addObject:bidResponse]; | ||
| } | ||
| [delegate didReceiveSuccessResponse:bidResponsesArray];; |
There was a problem hiding this comment.
Again questioning... why would u send success if this bidResponsesArray is nil or empty?
| adServerTargetingCopy[cacheIdkey] = bidderCacheId; | ||
| PBBidResponse *bidResponse = [PBBidResponse bidResponseWithAdUnitId:adUnitId adServerTargeting:adServerTargetingCopy]; | ||
| PBLogDebug(@"Bid Successful with rounded bid targeting keys are %@ for adUnit id is %@", [bidResponse.customKeywords description], adUnitId); | ||
| [bidResponsesArray addObject:bidResponse]; | ||
| } | ||
| [delegate didReceiveSuccessResponse:bidResponsesArray];; |
olafbuitelaar
pushed a commit
to olafbuitelaar/prebid-mobile-ios
that referenced
this pull request
Dec 25, 2018
PBM should not save the bid if targeting keys are not returned from server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.