Fix some race conditions #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons inside each adapter.
mkendall07
approved these changes
Oct 3, 2017
StarWindMoonCloud
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Jun 5, 2024
* roll out ggs2s to android article banner * Add tmax --------- Co-authored-by: Peiling-Ding <65974486+Peiling-Ding@users.noreply.github.com> Co-authored-by: Peiling Ding <peiling.ding@newsbreak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing more segfaults due to race conditions. This gist is a simplified version of the
/auctioncode flow. Run it withgo run -race main.goto see the race condition, and then re-run it after uncommenting the "copy" lines to show it fixedI think I got all the mutations, and documented which ones are "allowed" on
makeOpenRTBGeneric... but of course there's no way to be certain.I do think we need more general improvements so that these race conditions are less likely... but I'll log a separate issue for it shortly.