Yieldmo: Add gpid support #1935
Conversation
…as imp.ext.gpid in yieldmo request
| } | ||
|
|
||
| type ExtData struct { | ||
| PbAdslot string `json:"pbadslot"` |
There was a problem hiding this comment.
You added new bidder extension parameter. Do you want to update static/bidder-params/yieldmo.json file as well?
There was a problem hiding this comment.
Can you please update documentation PR as well? https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#user-documentation
There was a problem hiding this comment.
Hi Veronika,
Apologies for the delay in replying to your comment. My understanding is that pbadslot is an additional param coming in from the prebid SDK, and prebid server adapters can be updated to read it: https://docs.prebid.org/features/pbAdSlot.html
Since this is not a bidder specific param, I do not think it is necessary to add anything to static/bidder-params/yieldmo.json, or the user documentation. There are a few other adapters which are ingesting this field (grid, pubmatic), and they have not added it to their bidder.json files.
Please let me know if I am misinterpreting something. Thank you.
There was a problem hiding this comment.
Hi @ym-winston, I apologize, I didn't know about this. Thank you for pointing me to this!
…as imp.ext.gpid in yieldmo request (prebid#1935)
…as imp.ext.gpid in yieldmo request (prebid#1935)
add support for reading pbadslot in imp[].ext.data and outputting it as imp.ext.gpid in yieldmo request