IX: avoid htmlescaping in json encoding for native ad markup #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsardo and @mansinahar who were prebid reviewers on 1940. @grossjo for visibility as well. |
robhazan
approved these changes
Aug 2, 2021
mansinahar
approved these changes
Aug 4, 2021
jizeyopera
pushed a commit
to operaads/prebid-server
that referenced
this pull request
Oct 13, 2021
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of PR 1940 (#1940) which was closed due to employee departure from IX.
The last adapter change required merging eventtrackers with imptrackers in Native ad markup in the bid responses. Unfortunately go's standard json.Marshal function runs through HtmlEscape and replaces characters when encoding strings, and since native markup is sent as JSON encoded in JSON, this is causing issues in upstream servers when they receive the response.
This change uses a separate JSON encoder with HTML escaping disabled. Tests have been updated to include more complex URLs.