New Adapter: Groupm (Alias Of PubMatic) #2042
Conversation
|
@pm-isha-bharti Hey there! Can you please open a doc PR for this in the https://github.com/prebid/prebid.github.io repo? |
|
Hi @pm-isha-bharti. Just a reminder to please open a docs PR (https://github.com/prebid/prebid.github.io) before we merge. Thanks! |
| @@ -0,0 +1,18 @@ | |||
| maintainer: | |||
| email: "header-bidding@pubmatic.com" | |||
There was a problem hiding this comment.
Just checking, is this the right email?
There was a problem hiding this comment.
@bsardo Yes its correct, pubmatic will be the maintainer of groupm.
|
@pm-isha-bharti Friendly ping about the comments above. |
Sure, working on this |
|
Hey @pm-isha-bharti! Just wanted to check in on the progress on this one in regards to the above comments. |
Hi @mansinahar I have created this PR: prebid/prebid.github.io#3399 |
| "dctr": { | ||
| "type": "string", | ||
| "description": "Deals Custom Targeting, pipe separated key-value pairs e.g key1=V1,V2,V3|key2=v1|key3=v3,v5" | ||
| }, |
There was a problem hiding this comment.
I noticed what Mansi commented in your docs PR prebid/prebid.github.io#3399, about a difference in bidder params in this file vs. what you have in the docs PR. I was wondering if intended to add any variables from the docs PR to this file, or if you'll just update the docs PR to mirror what's in this groupm.json?
There was a problem hiding this comment.
@pm-isha-bharti based on your comment from the docs PR, I am assuming that you don't need to add any parameters here, correct?
There was a problem hiding this comment.
@pm-isha-bharti Just a friendly reminder about the above. If no changes are needed in the bidder params in Prebid Server, I believe we should be able to merge this one
There was a problem hiding this comment.
@mansinahar Yes, we don't need any changes in the bidder params JSON file. I have updated the PR prebid/prebid.github.io#3399 to include PBS bidder params in the documentation
* 'master' of https://github.com/wwwyyy/prebid-server: (23 commits) Add GPID Reserved Bidder Name (prebid#2107) Marsmedia adapter - param zoneId can get string and int (prebid#2105) Algorix: add Server Region Support (prebid#2096) New Adapter: Bizzclick (prebid#2056) Collect Prometheus Go process metrics (prebid#2101) Added channel support (prebid#2037) Rubicon: update fpd fields resolving (prebid#2091) Beachfront - Currency conversion (prebid#2078) New Adapter: Groupm (Alias Of PubMatic) (prebid#2042) Adform adapter lacked gross/net parameter support (prebid#2084) add iframe sync for openx (prebid#2094) changes to the correct user sync url (prebid#2092) Smaato: Add instl to tests (prebid#2089) Correct MakeRequests() output assertion in adapter JSON tests (prebid#2087) Adview: adapter currency fix. (prebid#2060) New Adapter: Coinzilla (prebid#2074) Syncer Level ExternalURL Override (prebid#2072) 33Across: Enable Support for SRA requests (prebid#2079) Currency conversion on adapter JSON tests (prebid#2071) New Adapter: VideoByte (prebid#2058) ...
No description provided.