New Adapter: Clickonometrics #2410
Conversation
openrtb_ext/imp_ccx.go
Outdated
| package openrtb_ext | ||
|
|
||
| type ExtImpCcx struct { | ||
| PlacementID string `json:"pid"` |
There was a problem hiding this comment.
Could you rename the json path to be json:"placementId"
There was a problem hiding this comment.
| err := &errortypes.BadInput{ | ||
| Message: "Unexpected status code: 400. Bad request from publisher. Run with request.debug = 1 for more info.", | ||
| } | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| if responseData.StatusCode != http.StatusOK { | ||
| err := &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode), |
There was a problem hiding this comment.
Is it possible to cover these two error cases?
|
There is a PR #2370 that is being merged today that will cause conflicts to new adapter PRs. To resolve these conflicts, you'll need to do the following: In In After the merge, you can look at other adapters to see how the server object is implemented as an example. |
adapters/ccx/ccx.go
Outdated
| return nil, []error{&errortypes.BadInput{ | ||
| Message: "No impression in the bid request", | ||
| }} | ||
| } |
There was a problem hiding this comment.
You do not need this check. The core logic of Prebid Server will only call this method if there is at least one impression.
|
Done |
bsardo
requested review from
hhhjort
and removed request for
VeronikaSolovei9
| capabilities: | ||
| site: | ||
| mediaTypes: | ||
| - banner |
There was a problem hiding this comment.
I'm noticing a discrepancy between the supported media types in this file vs. what's present in your dev docs. Here it says banner is the media type supported, but the doc says video. Could you address this?
There was a problem hiding this comment.
Thanks for updating your .yaml file, but could you also update your docs PR to include the banner media type as well?
There was a problem hiding this comment.
@AlexBVolcy I see PR #4127 was opened to address this.
|
@mjaworskiccx can you please merge with master when you get a chance? The 1.19 validation checks are failing because we recently upgraded to 1.19 and that version has made some updates to |
|
done |
|
Hi @mjaworskiccx, it looks like you have some failing tests due to some recent changes we made on master. You'll need to update the reference to the mxmcherry library with the prebid version of the ortb library. |
|
done |
No description provided.