Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter Name Case Insensitive: BidAdjustmentFactors Update #3210

Merged

Conversation

AlexBVolcy
Copy link
Contributor

There was a PR released to allow bidder names defined in ext.prebid.bidadjustmentfactors.BIDDER to be case insensitive: #3140

However, an update PR was needed for scenarios where the case style of a bidder in the bidadjustmentfactors was different from the bidder defined in the impression, would lead to the bidadjustmentfactor not being applied.

Along with that, extra validation was added, and tests.

@AlexBVolcy AlexBVolcy changed the title Case Insensitive Bidder Name: BidAdjustmentFactors (Update) Case Insensitive Bidder Name: BidAdjustmentFactors (Follow-Up) Oct 12, 2023
@bsardo bsardo assigned hhhjort and unassigned bsardo Oct 16, 2023
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo changed the title Case Insensitive Bidder Name: BidAdjustmentFactors (Follow-Up) Adapter Name Case Insensitive: BidAdjustmentFactors Update Oct 16, 2023
@SyntaxNode SyntaxNode merged commit f152b0d into prebid:master Oct 17, 2023
3 checks passed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants