Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Theadx #3498

Merged
merged 18 commits into from
Mar 7, 2024
Merged

New Adapter: Theadx #3498

merged 18 commits into from
Mar 7, 2024

Conversation

mustafakemal16
Copy link
Contributor

Theadx server adaptor added.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2b954b7

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@onkarvhanumante onkarvhanumante changed the title Theadx prebid server adaptor added New Adapter: Theadx Feb 14, 2024
SyntaxNode
SyntaxNode reviewed Feb 14, 2024
View reviewed changes
exchange/adapter_builders.go Outdated Show resolved Hide resolved
openrtb_ext/bidders.go Outdated Show resolved Hide resolved
openrtb_ext/bidders.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f1b7224

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f0b27ac

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, dde7749

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

mustafakemal16
mustafakemal16 commented Feb 15, 2024
View reviewed changes
Copy link
Contributor Author

@mustafakemal16 mustafakemal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theadx moved to alphabeticall order.

openrtb_ext/bidders.go Outdated Show resolved Hide resolved
mustafakemal16
mustafakemal16 commented Feb 15, 2024
View reviewed changes
Copy link
Contributor Author

@mustafakemal16 mustafakemal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes complete

adapters/theadx/theadx.go Show resolved Hide resolved
adapters/theadx/theadx.go Show resolved Hide resolved
openrtb_ext/bidders.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7811aaf

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

mustafakemal16
mustafakemal16 commented Feb 15, 2024
View reviewed changes
Copy link
Contributor Author

@mustafakemal16 mustafakemal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes complete

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7811aaf

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7811aaf

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 591be64

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@onkarvhanumante
Copy link
Contributor

onkarvhanumante commented Feb 26, 2024 •
edited by gargcreation1992

@mustafakemal16 should create docs PR in https://github.com/prebid/prebid.github.io repo. This PR is needed for include Theadx on prebid server docs - https://prebid.org/product-suite/prebid-server/

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2f8ff1b

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2615d88

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@mustafakemal16 mustafakemal16 mentioned this pull request Mar 4, 2024
Merged
8 tasks
@mustafakemal16
Copy link
Contributor Author

@mustafakemal16 should create docs PR in https://github.com/prebid/prebid.github.io repo. This PR is needed for include Theadx on prebid server docs - https://prebid.org/product-suite/prebid-server/

prebid/prebid.github.io#5184

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6d7029a

theadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:26:	getHeaders		76.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:49:	MakeRequests		70.0%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:92:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/theadx/theadx.go:136:	getMediaTypeForBid	83.3%
total:									(statements)		81.0%

@Sonali-More-Xandr Sonali-More-Xandr merged commit 7c4f5f1 into prebid:master Mar 7, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode left review comments

@onkarvhanumante onkarvhanumante onkarvhanumante left review comments

@github-actions github-actions[bot] github-actions left review comments

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mustafakemal16 @onkarvhanumante @SyntaxNode @gargcreation1992 @Sonali-More-Xandr