Add Ext.Prebid.Analytics Support #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBVolcy
commented
Mar 13, 2024
hhhjort
reviewed
Mar 13, 2024
analytics/build/build.go
Outdated
| // Given analytics adapter module is not present in ext.prebid.analytics, remove the entire analytics object from request for logging | ||
| if _, ok := extPrebidAnalytics[adapterName]; !ok { | ||
| reqExtPrebid.Analytics = nil | ||
| reqExt.SetPrebid(reqExtPrebid) |
There was a problem hiding this comment.
At this point, we will be modifying the original request wrapper sent in to LogAuctionObject() at the top of this file unless evaluateActivities() found something it needed to change and thus has already cloned the request wrapper. You probably need to record a isCloned flag and pass it down here, so you can know if you need to clone the request wrapper before modifying the Analytics object.
There was a problem hiding this comment.
My latest commits should address this, and I added tests that should've caught this issue initially!
hhhjort
reviewed
Mar 13, 2024
hhhjort
reviewed
Mar 25, 2024
analytics/build/build_test.go
Outdated
| } | ||
|
|
||
| func TestLogAnalyticsObjectExtRequestPrebidAnalytics(t *testing.T) { | ||
| func (m *secondMockAnalytics) LogVideoObject(vo *analytics.VideoObject) { |
There was a problem hiding this comment.
Why do you have two independent struct types rather than one type with two independent instances?
VeronikaSolovei9
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue: #1800
The goal of this PR is to add a new object on the request:
bidrequest.ext.prebid.analyticsand pass this object to analytics adapters.The object that will live at this path will be
ExtPrebidAnalytics: {name_of_analytics_adapter: {client-analytics: bool}}Before the object is made available to the analytics adapters through the various
LogObjectfunctions inbuild.go, PBS-Go will loop over the new analytics object on the request, and before logging for a specific analytics adapter, we'll update the request that's being logged to only include the analytics information for that specific adapter.