Flipp + Alkimi: Minor Refactoring #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
alkimiRefer here for heat map coverage report flippRefer here for heat map coverage report |
SyntaxNode
commented
Apr 10, 2024
| @@ -59,12 +63,12 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E | |||
| adapterRequests = append(adapterRequests, adapterReq) | |||
| } | |||
| if len(adapterRequests) == 0 { | |||
| return nil, append(errors, fmt.Errorf("adapterRequest is empty")) | |||
There was a problem hiding this comment.
There's no need for fmt.Errorf with a fixed string. Hoisted the error to a top level variable to be more sensitive to allocations.
| // Builder builds a new instance of the Flipp adapter for the given bidder with the given config. | ||
| func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { | ||
| uuidGenerator = uuidutil.UUIDRandomGenerator{} |
There was a problem hiding this comment.
The uuidGenerator should be scoped to the adapter instance per our rules. This is to avoid memory access issues if there are adapter aliases specified.
|
@SyntaxNode The change looks fine on alkimi adapter. Thanks. |
|
@SyntaxNode the changes on Flipp adapter looks good. Thank you for making those! |
gargcreation1992
approved these changes
Apr 25, 2024
onkarvhanumante
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing the code to see if any new adapters needed to have ImpIDs added. We're all good though, thanks very much to @pmsaurabh-narkhede.
It was harder for me to quickly see the ImpIDs implementation for Flipp + Alkimi, so I'm proposing a minor refactor to make it easier. Also noticed some policy violations in Flipp and are correcting them here.
Flipp: @hasan-kanjee
Alkimi: @kalidas-alkimi