PulsePoint: Marking cp/ct params to be either String or Int #3677

anand-venkatraman · 2024-05-09T18:17:15Z

No description provided.

github-actions · 2024-05-09T19:32:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 929b96b

pulsepoint

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:29:	MakeRequests	95.6%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:106:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:153:	getBidType	88.9%
total:										(statements)	96.2%

onkarvhanumante · 2024-05-22T08:14:13Z

static/bidder-params/pulsepoint.json

+      "type": [
+        "integer",
+        "string"
+      ],
      "description": "An ID which identifies the publisher selling the impression"
    },
    "ct": {
-      "type": "integer",
+      "type": [
+        "integer",
+        "string"
+      ],


@anand-venkatraman could you add JSON test where cp and ct are string

@anand-venkatraman requesting to address above comment ^^

sorry for the delay, i have added a few tests cases to validParams under params_test.go file.

@anand-venkatraman thanks for adding params test. Requesting to add Json framework tests as well for scenario where cp and ct are string in imp.ext

addressed in commit 4539af1

static/bidder-params/pulsepoint.json

github-actions · 2024-06-03T14:27:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e732c3f

pulsepoint

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:29:	MakeRequests	95.6%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:106:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:153:	getBidType	88.9%
total:										(statements)	96.2%

github-actions · 2024-06-12T12:35:36Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4539af1

pulsepoint

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:30:	MakeRequests	88.7%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:121:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:168:	getBidType	88.9%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:182:	parseParam	100.0%
total:										(statements)	92.5%

onkarvhanumante · 2024-06-26T16:56:39Z

openrtb_ext/imp_pulsepoint.go

+	PubID interface{} `json:"cp"`
+	TagID interface{} `json:"ct"`


PubID and TagID are expected to be int or string.
However interface{} will allow int, string and any other values

Should use StringInt type

prebid-server/util/jsonutil/stringInt.go

Lines 1 to 29 in a1f48b5

package jsonutil

import (

"github.com/buger/jsonparser"

)

type StringInt int

func (st *StringInt) UnmarshalJSON(b []byte) error {

if len(b) == 0 {

return nil

}

if b[0] == '"' {

b = b[1 : len(b)-1]

}

if len(b) == 0 {

return nil

}

i, err := jsonparser.ParseInt(b)

if err != nil {

return err

}

*st = StringInt(i)

return nil

}

updated params to use StringInt instead of interface{}

onkarvhanumante

one comment - https://github.com/prebid/prebid-server/pull/3677/files#r1655235030

github-actions · 2024-06-28T20:11:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 394b0da

pulsepoint

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:32:	MakeRequests	92.5%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:123:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:170:	getBidType	88.9%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:184:	parseParam	100.0%
total:										(statements)	94.5%

github-actions · 2024-06-28T20:15:06Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0a2a52c

pulsepoint

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:25:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:32:	MakeRequests	92.5%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:123:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:170:	getBidType	88.9%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:184:	parseParam	100.0%
total:										(statements)	94.5%

github-actions · 2024-06-28T20:19:09Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f4c20f4

pulsepoint

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:24:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:31:	MakeRequests	92.5%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:169:	getBidType	88.9%
github.com/prebid/prebid-server/v2/adapters/pulsepoint/pulsepoint.go:183:	parseParam	100.0%
total:										(statements)	94.4%

)

anand-venkatraman added 2 commits May 9, 2024 23:39

Marking cp/ct params to be either String or Int

3730923

fixing test

929b96b

gargcreation1992 assigned gargcreation1992 and onkarvhanumante May 13, 2024

gargcreation1992 previously approved these changes May 13, 2024

View reviewed changes

bsardo changed the title ~~PulsePoint Adapter: Marking cp/ct params to be either String or Int~~ PulsePoint: Marking cp/ct params to be either String or Int May 13, 2024

onkarvhanumante reviewed May 22, 2024

View reviewed changes

static/bidder-params/pulsepoint.json Show resolved Hide resolved

adding tests for valid string parameters for ct/cp

e732c3f

anand-venkatraman dismissed gargcreation1992’s stale review via e732c3f June 3, 2024 14:26

Adding json framework tests and some fixes

4539af1

gargcreation1992 previously approved these changes Jun 17, 2024

View reviewed changes

onkarvhanumante reviewed Jun 26, 2024

View reviewed changes

onkarvhanumante requested changes Jun 26, 2024

View reviewed changes

addressing review comment to use StringInt

394b0da

anand-venkatraman dismissed gargcreation1992’s stale review via 394b0da June 28, 2024 20:10

running gofmt

0a2a52c

minor refactor

f4c20f4

onkarvhanumante approved these changes Jul 1, 2024

View reviewed changes

gargcreation1992 approved these changes Jul 1, 2024

View reviewed changes

gargcreation1992 merged commit a907ecb into prebid:master Jul 1, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jul 1, 2024

Port PR from PBS-Go: PulsePoint: Marking cp/ct params to be either String or Int prebid/prebid-server-java#3276

Closed

mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024

PulsePoint: Marking cp/ct params to be either String or Int (prebid#3677

48b15c0

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PulsePoint: Marking cp/ct params to be either String or Int #3677

PulsePoint: Marking cp/ct params to be either String or Int #3677

anand-venkatraman commented May 9, 2024

github-actions bot commented May 9, 2024

onkarvhanumante May 22, 2024

onkarvhanumante Jun 3, 2024

anand-venkatraman Jun 3, 2024

onkarvhanumante Jun 11, 2024

anand-venkatraman Jun 12, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024

github-actions bot commented Jun 12, 2024

onkarvhanumante Jun 26, 2024

anand-venkatraman Jun 28, 2024

onkarvhanumante left a comment

github-actions bot commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

	package jsonutil

	import (
	"github.com/buger/jsonparser"
	)

	type StringInt int

	func (st *StringInt) UnmarshalJSON(b []byte) error {
	if len(b) == 0 {
	return nil
	}

	if b[0] == '"' {
	b = b[1 : len(b)-1]
	}

	if len(b) == 0 {
	return nil
	}

	i, err := jsonparser.ParseInt(b)
	if err != nil {
	return err
	}

	*st = StringInt(i)
	return nil
	}

PulsePoint: Marking cp/ct params to be either String or Int #3677

PulsePoint: Marking cp/ct params to be either String or Int #3677

Conversation

anand-venkatraman commented May 9, 2024

github-actions bot commented May 9, 2024

Code coverage summary

pulsepoint

onkarvhanumante May 22, 2024

Choose a reason for hiding this comment

onkarvhanumante Jun 3, 2024

Choose a reason for hiding this comment

anand-venkatraman Jun 3, 2024

Choose a reason for hiding this comment

onkarvhanumante Jun 11, 2024

Choose a reason for hiding this comment

anand-venkatraman Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jun 3, 2024

Code coverage summary

pulsepoint

github-actions bot commented Jun 12, 2024

Code coverage summary

pulsepoint

onkarvhanumante Jun 26, 2024

Choose a reason for hiding this comment

anand-venkatraman Jun 28, 2024

Choose a reason for hiding this comment

onkarvhanumante left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 28, 2024

Code coverage summary

pulsepoint

github-actions bot commented Jun 28, 2024

Code coverage summary

pulsepoint

github-actions bot commented Jun 28, 2024

Code coverage summary

pulsepoint

anand-venkatraman Jun 12, 2024 •

edited

Loading