Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: MetaX #3712

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

New Adapter: MetaX #3712

wants to merge 6 commits into from
+2,784 −0

Conversation

metax-kehan
Copy link

New adapter for metaxsoft.com

@metax-kehan
New Adapter: MetaX
bb36d45 
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
github-actions[bot]
github-actions bot reviewed May 30, 2024
View reviewed changes
adapters/metax/metax.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bb36d45

metax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/metax/metax.go:27:	MakeRequests			75.8%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:88:	MakeBids			88.2%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:128:	getEndpoint			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:136:	parseBidderExt			71.4%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:151:	validateParams			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:161:	preprocessImp			81.8%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:186:	assignBannerSize		100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:194:	assignBannerWidthAndHeight	100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:201:	getBidType			55.6%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:222:	Builder				71.4%
total:								(statements)			79.6%

@metax-kehan
MetaX: rename adapter struct name
7d24b8d 
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7d24b8d

metax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/metax/metax.go:27:	MakeRequests			75.8%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:88:	MakeBids			88.2%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:128:	getEndpoint			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:136:	parseBidderExt			71.4%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:151:	validateParams			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:161:	preprocessImp			81.8%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:186:	assignBannerSize		100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:194:	assignBannerWidthAndHeight	100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:201:	getBidType			55.6%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:222:	Builder				71.4%
total:								(statements)			79.6%

@metax-kehan
MetaX: add more test cases
d3f88ed 
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d3f88ed

metax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/metax/metax.go:27:	MakeRequests			81.8%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:88:	MakeBids			94.1%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:128:	getEndpoint			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:136:	parseBidderExt			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:151:	validateParams			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:161:	preprocessImp			93.3%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:190:	assignBannerSize		100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:202:	assignBannerWidthAndHeight	100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:209:	getBidType			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:230:	Builder				85.7%
total:								(statements)			91.3%

@onkarvhanumante
Copy link
Contributor

@metax-kehan should update json test

  • to have request with multiple imps
  • to have multi-format imp request

@metax-kehan
MetaX: fixed new adapter issues
09cc018 
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 09cc018

metax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/metax/metax.go:26:	MakeRequests			77.8%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:75:	MakeBids			94.4%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:111:	getEndpoint			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:119:	parseBidderExt			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:133:	preprocessImp			87.5%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:149:	assignBannerSize		80.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:161:	assignBannerWidthAndHeight	100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:168:	getBidType			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:186:	Builder				85.7%
total:								(statements)			88.1%

@onkarvhanumante
Copy link
Contributor

@metax-kehan please link bidder docs PR to this PR

@metax-kehan metax-kehan mentioned this pull request Jun 14, 2024
Open
8 tasks
@metax-kehan
Copy link
Author

@onkarvhanumante all the issues have been resolved, and the document PR is linked and seems ready to merge. could we go next and let this PR reviewed and merged? please let me know if there anything need i do, thanks

@metax-kehan
MetaX: adds test cases
db21fa6 
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, db21fa6

metax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/metax/metax.go:26:	MakeRequests			92.6%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:75:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:111:	getEndpoint			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:119:	parseBidderExt			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:133:	preprocessImp			87.5%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:149:	assignBannerSize		100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:161:	assignBannerWidthAndHeight	100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:168:	getBidType			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:186:	Builder				100.0%
total:								(statements)			96.4%

onkarvhanumante
onkarvhanumante requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@onkarvhanumante onkarvhanumante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3712 (comment)

@metax-kehan PTAL at above comment

@metax-kehan
MetaX: add comment and refine always nil issue
b4ec7b5 
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b4ec7b5

metax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/metax/metax.go:26:	MakeRequests			92.6%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:75:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:111:	getEndpoint			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:119:	parseBidderExt			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:133:	preprocessImp			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:145:	assignBannerSize		100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:157:	assignBannerWidthAndHeight	100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:164:	getBidType			100.0%
github.com/prebid/prebid-server/v2/adapters/metax/metax.go:182:	Builder				100.0%
total:								(statements)			97.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@onkarvhanumante onkarvhanumante Awaiting requested review from onkarvhanumante

Requested changes must be addressed to merge this pull request.

Assignees

@onkarvhanumante onkarvhanumante

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@metax-kehan @onkarvhanumante @Sonali-More-Xandr @przemkaczmarek