Smaato: Change server response type #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
Merged
| @@ -57,7 +57,8 @@ type bidRequestExt struct { | |||
|
|
|||
| // bidExt defines Bid.Ext object for Smaato | |||
| type bidExt struct { | |||
| Duration int `json:"duration"` | |||
| Duration int `json:"duration"` | |||
| Curls []string `json:"curls"` | |||
There was a problem hiding this comment.
What is the main purpose of adding the Curls field to the bidExt structure? Can you provide examples of situations where it will be used?
There was a problem hiding this comment.
@przemkaczmarek
yes it is click urls array
use case is to track ads clicks - both our own and potentially demand partners - and since there is no ortb specific field for this we decided to use ext
przemkaczmarek
previously approved these changes
Jul 17, 2024
bsardo
reviewed
Jul 22, 2024
adapters/smaato/banner_test.go
Outdated
| expectedAdMarkup string | ||
| }{ | ||
| { | ||
| testName: "extract banner without curls", |
There was a problem hiding this comment.
Nitpick: I suggest replacing the spaces with underscores in your test names (e.g. extract_banner_without_curls). t.Run will automatically convert them to underscores but it would be better to avoid that so it is easier to find failed tests via a search without having to consider this possibility.
There was a problem hiding this comment.
renamed and fixed the merge conflicts for both PRs
Enigo
force-pushed
the
feature/SCORE-16207_Q_prebid_migrate_away_from_api_v6_type_of_responses
branch
from
8906df3
to
b2188fa
Compare
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
bsardo
approved these changes
Jul 23, 2024
przemkaczmarek
approved these changes
Jul 23, 2024
|
@bsardo @przemkaczmarek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've simplified our server response to make it more ortb-like
Backward compatibility is guaranteed server-side