Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YieldOne Bid Adapter: Update doc. #3335

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

kyoya-takei
Copy link
Contributor

YieldOne Bid Adapter: Update doc.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a prebid change going along with this? If yes, please link the PR in a comment here 🤗

| Name | Scope | Description | Example | Type |
|-----------------|----------|----------------------------------|--------------|-------------------|
| `placementId` | required | The placement ID | `"36891"` | `string` |
| `playerSize` | optional | Video Resolution Size<br/>(This field is mandatory if mediaTypes.video.playerSize is [1, 1]) | `[640, 360]` | `array of number` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any further information on the player available, e.g.

  • what does 1x1 trigger? A responsive player?
  • is the actual playerSize setting obeyed or is the player still changing its size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because video can only be set to one size, it is not always possible to set a common size when various bidder are connected. In such cases, there are cases where 1x1 is used. However, in our server, sending a request with 1x1 will result in a bad request due to a size error, so it is necessary to adjust the playerSize. Currently, there is no plan to deal with size errors on the server side, so we use playerSize to deal with it.

@muuki88 muuki88 self-assigned this Oct 12, 2021
@muuki88 muuki88 added the LGTM label Oct 12, 2021
@kyoya-takei
Copy link
Contributor Author

A prebid change along with this is below :
prebid/Prebid.js#7555

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that the PBJS yieldone adapter already supports these params

@bretg bretg merged commit c914867 into prebid:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants