Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videobyte - Update media types and note #3490

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

videobyte20
Copy link
Contributor

No description provided.

gdpr_supported: true
usp_supported: true
schain_supported: true
---

### Note:

VideoByte adapter only supports video ads.
VideoByte Prebid Client adapter only supports video ads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@videobyte20
On line 8 you have updated the field to say you support both display and video. I'm confused by this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display is supported when using Prebid Server, but not when using Prebid Client. How should we indicate this? Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

"The VideoByte Prebid.js client adapter only supports video ads while our Prebid Server adapter supports both display and video."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with your suggestion, thanks!

@bretg
Copy link
Contributor

bretg commented Jan 19, 2022

Thanks for the update. Next question: is there a code pull request associated with this docs PR? I don't see anything in the Prebid.js repo.

@videobyte20
Copy link
Contributor Author

Thanks for the update. Next question: is there a code pull request associated with this docs PR? I don't see anything in the Prebid.js repo.

No, this PR is just for updating the docs. This PR was the latest Prebid Server update prebid/prebid-server#2058.

One question for you - VideoByte is listed here in the list https://docs.prebid.org/dev-docs/pbs-bidders.html, but when the link is clicked nothing happens. Can you take a look please?

@bretg bretg merged commit 798704c into prebid:master Jan 20, 2022
@bretg
Copy link
Contributor

bretg commented Jan 20, 2022

Ugh - sorry, another adapter doc file had a typo so it screwed up everyone beneath it. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants