Mobile SDK multiformat feature #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ValentinPostindustria
force-pushed
the
mobile_sdk_mutliformat_changes
branch
from
52e89e4
to
89a8b54
Compare
YuriyVelichkoPI
requested review from
ChrisHuie and
bretg
and removed request for
YuriyVelichkoPI
|
We need someone from the mobile committee to review this doc. Neither Chris nor I have the background to properly review this. @mmullin, could you suggest someone? |
bretg
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
My review is really not authoritative, but I skimmed it. My feedback:
- deprecated things (e.g. DISPLAY) need to be highlighted in the release notes. (I'm assuming DISPLAY still works. Shouldn't remove that until 3.0 IMO)
- I don't think it's intuitive that multiformat adunits are created with a function called
BannerAdUnit. But I suppose that can be addressed in a future release.
|
Hi @bretg ! We added info about deprecated items to the release notes on both platforms. And yes, deprecated classes, functions, and enum cases still work as expected. |
myDisconnect
pushed a commit
to eskimi/prebid.github.io
that referenced
this pull request
May 23, 2023
* Update iOS documentation. * iOS documentation corrections. * Update Android documentation. * Android corrections. * iOS corrections. * Android ad unit formats renaming. * iOS AdFormat case renaming * doc: corrections for iOS * doc: corrections for Android --------- Co-authored-by: Olena Stepaniuk <olena.stepaniuk@postindustria.com> Co-authored-by: Yuriy Velichko <yuriy.velichko@postindustria.com>
ecdrsvc
pushed a commit
to ecdrsvc/prebid.github.io
that referenced
this pull request
Sep 6, 2023
* Update iOS documentation. * iOS documentation corrections. * Update Android documentation. * Android corrections. * iOS corrections. * Android ad unit formats renaming. * iOS AdFormat case renaming * doc: corrections for iOS * doc: corrections for Android --------- Co-authored-by: Olena Stepaniuk <olena.stepaniuk@postindustria.com> Co-authored-by: Yuriy Velichko <yuriy.velichko@postindustria.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Prebid Mobile documentation for the multiformat feature. Added sultiformat examples.
🏷 Type of documentation