Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonobi add hfa docs #594

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Sonobi add hfa docs #594

merged 3 commits into from
Feb 27, 2018

Conversation

bansawbanchee
Copy link
Contributor

Adding a new parameter to the docs.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This can get merged after the 1.3 release

@rmloveland rmloveland added the LGTM label Feb 6, 2018
@rmloveland rmloveland removed the LGTM label Feb 13, 2018
@rmloveland
Copy link
Contributor

@bansawbanchee looks like you had 2 open PRs and I merged the other one. If there's still something in here you need, can you please fix the conflicts? Otherwise let's close - thanks!

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix conflicts

@bretg
Copy link
Contributor

bretg commented Feb 27, 2018

fixed conflict

@bretg bretg merged commit fa8fbb8 into prebid:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants