New naming scheme #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
Mar 24, 2019
|
Looking really good! See my one comment |
mafintosh
approved these changes
Mar 24, 2019
18 tasks
| if (a.runtime !== b.runtime) { | ||
| return a.runtime === runtime ? -1 : 1 | ||
| } else if (a.abi !== b.abi) { | ||
| return a.abi ? -1 : 1 |
There was a problem hiding this comment.
@vweevers Mind explaining this a bit?
There was a problem hiding this comment.
We want to pick a prebuild that most closely matches the runtime (environment).
By this point in the code, we have already filtered out prebuilds with non-matching tags. But let's say the current runtime is Electron. There could still be:
- A prebuild specifically targeting Electron
- A runtime-agnostic prebuild (suitable for both Node and Electron)
If (1) exists, it should sort first and win. We're assuming that if (1) exists, it must mean that (2), though agnostic for most runtimes, is not suitable for this specific runtime.
The logic is the same for the ABI's. At this point in the code, we could have:
- A prebuild specifically targeting the current ABI
- An "ABI-agnostic" prebuild (i.e. N-API)
If (1) exists, it should sort first and win.
ralphtheninja
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of prebuild/prebuildify#27. Major.