Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update node-abi so that electron 14+ get correct node-abi #161

Merged
merged 2 commits into from
Nov 12, 2021
Merged

deps: update node-abi so that electron 14+ get correct node-abi #161

merged 2 commits into from
Nov 12, 2021

Commits on Nov 7, 2021

  1. deps: update node-abi so that electron 14+ get correct node-abi 

    electron/node-abi#113 was fixed in 3.3.0
and is affecting electron 14+

With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.
    @csett86
    csett86 committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    f7be437 View commit details
    Browse the repository at this point in the history

  2. Drop support for node < 10 

    node-abi 3.0.0 did so too
    @csett86
    csett86 committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    64cd9c5 View commit details
    Browse the repository at this point in the history