Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the adapter for preCICE v3 and add test cases for Elmer-OpenFOAM coupling #4

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

tapegoji
Copy link

@tapegoji tapegoji commented Jul 1, 2024

Description

  • Ported Elmer adapter from preCICE v2 to v3.
  • Added comprehensive test cases for coupling Elmer with OpenFOAM.
  • Ensured compatibility and improved integration with the latest preCICE version.

Changes:

  • Updated adapter files to align with preCICE v3 API.
  • Included new test cases for Elmer to OpenFOAM coupling. This change required hard-coded naming translation in the Coupler_Solver.F90 code.
  • Enhanced documentation to reflect the changes and new usage instructions.

Testing:

  • Successfully ran all new test cases to verify the adapter's functionality with preCICE v3 and OpenFOAM.
  • Ensured backward compatibility and verified no breaking changes with existing setups.

Additional Notes:

  • Please review the updated documentation and test cases.
  • Looking forward to feedback and suggestions for further improvements.

tapegoji and others added 2 commits July 1, 2024 12:16
…mer to OpenFoam. A hard-coded naming convection was added to CoupleSolver.F90 for Elmer <-> OF coupling.
Ported the adapter for elmer from v2 to v3. Added a case to couple El…
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot already! As this change is a bit larger, please be patient with the review 😁

Two things already to simplify the review. Please

  • Remove the precice-profiling folders
  • Strip the tools to what you actually need

@tapegoji
Copy link
Author

tapegoji commented Jul 5, 2024

I have removed the precice-profiling and the extra files in the tools folder. Let me know if you need anything else. I am happy to help make this a great tool.
Regards,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log file can be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README would be better suited on main folder level

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapegoji thanks a lot for this contribution! Great work already 👏 Please have a look at my review comments. I did not run the test case and also did not have a look at the OpenFOAM things. After we do one iteration of the review, I can try running things. We can then finalize this pull request.

@IshaanDesai IshaanDesai self-assigned this Jul 8, 2024
@IshaanDesai IshaanDesai added the breaking change A change will break backwards compatibilty label Jul 8, 2024
@IshaanDesai IshaanDesai changed the title Update Elmer Adapter for preCICE v3 and Add Test Cases for Elmer to OpenFOAM Coupling Update the adapter for preCICE v3 and add test cases for Elmer-OpenFOAM coupling Jul 8, 2024
tapegoji and others added 13 commits July 12, 2024 09:43
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change will break backwards compatibilty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants